The 1850 Census lists his children:
Elizabeth b. 1824
David  b. 1825
Catherine  b. 1828
Hiram  b. 1835
John b. 1844 (This John could have been the son OR grandson of Samuel O’Shields.)

It appears David O’Shields  was the oldest son of Samuel O’Shields.
David O’Shields married Nancy Neal, 15 December 1850, Lumpkin County, Georgia (Source: Marriage date Extracted from research by B. Kerby via Internet)
1870 Census, Dawson County, Georgia
David O’Shields, b. 1820
Nancy  b. 1830   (maiden name, NEAL, per B. Kerby)
Children of this couple:  1870 Census, Dawson County, Georgia
Elizabeth b. 1852    (1880 Mary E. O’Shields)
Merrady  b. 1856   (1880 Census, Meredith O‘Shields)
Miles  b. 1857       (Miles Frank O‘Shields, 1910 Census, Dawson County)
George  b. 1860    (1880 Census, George W. O‘Shields)
{One additional person was listed, Martin Smith. The census record stated Martin was age 23 and female. This is incorrect. Martin Smith was male, the son of Eli Smith and Nancy, per 1850 Census, Dawson County.)
Why wasn’t Sarah Ann O’Shields listed in this census record as a child of David O’Shields and wife, Nancy?  She was listed in the 1880 Census only.}
{B. Kerby via Internet stated David O’Shields and Nancy Neal had son named James O’Shields, 1859.}

After a careful examination of Census Records, I have concluded David O’Shields’ wife, Nancy, was married first to Eli Smith, who died after 4 November 1850.
1850 Census Dawson County, Georgia (4 November 1850)
Eli SMITH  b. 1823
Nancy Smith   b. 1830
James Smith b. 1844      (He is possibly the James O’Shields named by B. Kerby.)
Martin Smith  b. 1847   (1870 Census with NANCY O’Shields and David O’Shields)
Collin  b. 1849       (I believe his name to have been John Collins Smith.)

1880 Census, Dawson County, Georgia
David O’Shields    (Nancy died by 1880 Census)
One additional child was listed:
Sarah A. b. 1865   (Sarah A. O’Shields)

1900 Census, Fulton County, Georgia, This record stated Elizabeth O’Shields was the mother of 11 and 10 were living.
Hiram O’Shields   b. March 1836   (son of Samuel O’Shields)
Elizabeth (maiden name Manning)   b. May 1832
Children:
Nora b. February 1876

NEXT DOOR  in the same 1900 Census
Henry O’Shields  b. May 1873
Savanna  b. 1875
Children:
Zadia  b. 1894
Ethel M.  b. 1897

I believe Hiram O’Shields, Sr., was the father of these children:
John Hiram  b. 29 June 1864   (married Sarah Elizabeth Dowda)
Benjamin H.  b. August 1870  (married Octavia Palestine Dowda)
Henry  b. May 1873  (married Savannah)
Nora  b. February 1876

Two Brothers who married Two Sisters:
John Hiram O’Shields b. 29 June 1864 in Georgia, married Sarah Elizabeth DOWDA on 3 May 1891, in Cobb County, Georgia.  Sarah Elizabeth Dowda was born January 1869 in Georgia.
Children born to this couple:
Carlos b. June 1892
Pearl  b. April 1897
Clifford b. 1903   (married Bertha Bizzell, 6 July 1935, Cobb County, Georgia)
Henry G.  b. 1909

Benjamin H. O’Shields, b. August 1870, Georgia, and d. 10 April 1930.  He married Octavia Palestine DOWDA, 2 December 1891, in Cobb County, Georgia.  Octavia was born  November 1872 in Georgia and died 1960.
Children born to this couple:
Albert   b. October 1892
Roy B. b. May 1894
Maggie  b. January 1899
Claude  b. 1902

(Source: “Final Payment Vouchers Index Military Pensions” 1818-1864.)
John Osheal received final payment for his service in the Revolutionary War during the Fourth Quarter of 1844; thus giving us the approximate date of John OSheal’s death.
John OSheal died sometime between 1 October 1844 and 31 December 1844.  I am sure John OSheal’s descendants will be happy to know I located this important document.

Of further interest to the descendants of John OSheal:

After I located the approximate date of death for John OSheal, s/o Daniel OSheal and Sarah Walker, I realized Lucretia O’Shields appearing in the 1846 Minutes of the Friendship Baptist Church could not have been the widow of John OSheal, the Rev. War soldier because in 1861 John OSheal’s grandson, stated when John OSheal died he left NO WIDOW. John OSheal died between 1 Oct. 1844 and 31 Dec. 1844, leaving NO WIDOW.
Lucretia O’Shields who appears in the Friendship Church Minutes in 1846 was not the wife of John OSheal, but she most certainly could have been the wife of Jethro OSheal.